feat: Generate completions during build process #53
Conversation
This commit adds a `build.rs` which generates completion files for Bash, Elvish, Fish, and zsh shells. In order to accomplish this, the `build_cli` command was moved into a separate module: `cli`. The CI build script was also modified to package the four scripts into the outputted build artifact. One downside of pre-generating the completion scripts is that it won't be able to take user-specified profiles, as those are dependent on each system. That would require custom generations, and would probably no longer able to be auto-generated with clap.
|
@DSpeckhals nice to see we are close to have some decent packaging for various distro. |
oknozor
force-pushed
the
v2.0.0-rc
branch
16 times, most recently
from
ebd4bdf
to
888b90b
Compare
|
It would also be good to update to clapv3 beforehand. The way completion files are generated changed a bit with their v3 release, as there's now a dedicated crate for this functionality. I assume this whole PR would need to be rewritten anyway, as it probably also makes sense to use clap via their new "structopt" declaration while you're at it. It's also the recommended way to use clap right now. |
|
This MR is old and has conflicts. Is @DSpeckhals willing to pick this back up? |
|
Closing this since there is no activity. |
|
I think this can be closed as "done", as there's now a subcommand to generate auto-completions at all :) Moving them to the correct location in the system is indeed the distro packager's job |
|
For the record, Arch has had those for quite some time now. |
This commit adds a
build.rswhich generates completion files for Bash,Elvish, Fish, and zsh shells. In order to accomplish this, the
build_clicommand was moved into a separate module:cli. The CIbuild script was also modified to package the four scripts into the
outputted build artifact.
One downside of pre-generating the completion scripts is that it won't
be able to take user-specified profiles, as those are dependent on each
system. That would require custom generations, and would probably no
longer able to be auto-generated with clap.
Note: I have not actually tested out the CI script yet. I would recommend doing that before merging this.
Fixes #53